[ 
https://issues.apache.org/jira/browse/DIRSTUDIO-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222614#comment-16222614
 ] 

Lothar Haeger edited comment on DIRSTUDIO-1156 at 10/27/17 4:10 PM:
--------------------------------------------------------------------

So I've changed then HexDialog and TextDialog classes as described above, just 
the "wrap lines" check box has become toggle button instead. Please see 
attached DIRSTUDIO-1156-1.patch

[~elecharny]: would you be so kind and review the patch and apply to trunk if 
you see fit?

PS: my French did not come up with a good translation to "wrap lines" or 
"Zeilenumbruch" yet, please feel free to change the last line of the patch (-> 
message_fr.properties)


was (Author: lhaeger):
So I've changed then HexDialog and TextDialog classes as described above, just 
the "wrap lines" check box has become toggle button instead. Please see 
attached DIRSTUDIO-1156-1.patch

[~elecharny]: would you be so kind and review the patch and apply to trunk if 
you see fit?

> Text Editor usability improvements
> ----------------------------------
>
>                 Key: DIRSTUDIO-1156
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-1156
>             Project: Directory Studio
>          Issue Type: Improvement
>          Components: studio-ldapbrowser
>    Affects Versions: 2.0.0-M13
>         Environment: Windows
>            Reporter: Lothar Haeger
>            Assignee: Lothar Haeger
>            Priority: Minor
>              Labels: usability
>         Attachments: DIRSTUDIO-1156_1.patch
>
>
> As an IDM developer I work a lot with XML blobs stored in binary attributes. 
> Those values open in Hex Editor initially, which has a "Edit as Text..." 
> button to open the value in a Text Editor if possible (i.e. not containing 
> any non-printable characters). There are a few aspects to improve here, 
> especially when working with long lines of text or overall large texts:
> * the Text Editor cannot be maximized on all platforms. SWT.RESIZE is set, 
> but is a lot less convenient to use if you need as much screen area as 
> possible. Possible solution: add SWT.MAX when creating the dialog
> * the Text Editor does not support line wrapping. XML or JSON data is often 
> stored without line breaks, which requires cumbersome horizontal scrolling. 
> Possible solution: add a "wrap lines" check box (display only, not adding 
> line breaks to the value text, inactive by default)
> * the Text Editor dialog has a relatively small default size, a  ~50% 
> wider/higher seems reasonable
> * the button to open the Text Editor from Hex Editor is always displayed, 
> even if the binary value is not editable (e.g. contains an image). Only when 
> the button has been pressed a check is performed and an error message shown. 
> It would be more intuitive to hide the button if a binary value cannot be 
> edited as text in the first place.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to