[
https://issues.apache.org/jira/browse/DIRSTUDIO-861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439938#comment-16439938
]
ASF GitHub Bot commented on DIRSTUDIO-861:
------------------------------------------
seelmann closed pull request #1: DIRSTUDIO-861 - Strings.toLowerCase()
shouldn't be used for attribute values.
URL: https://github.com/apache/directory-studio/pull/1
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/plugins/ldapbrowser.core/src/main/java/org/apache/directory/studio/ldapbrowser/core/utils/Utils.java
b/plugins/ldapbrowser.core/src/main/java/org/apache/directory/studio/ldapbrowser/core/utils/Utils.java
index cd33c380d..fb18393a3 100644
---
a/plugins/ldapbrowser.core/src/main/java/org/apache/directory/studio/ldapbrowser/core/utils/Utils.java
+++
b/plugins/ldapbrowser.core/src/main/java/org/apache/directory/studio/ldapbrowser/core/utils/Utils.java
@@ -130,7 +130,7 @@ private static String getOidString( Ava ava, Schema schema )
String oid = schema != null ? schema.getAttributeTypeDescription(
ava.getNormType() ).getOid() : ava
.getNormType();
return Strings.toLowerCase( Strings.trim( oid ) )
- + "=" + Strings.toLowerCase( Strings.trim(
ava.getValue().getString() ) ); //$NON-NLS-1$
+ + "=" + Strings.trim( ava.getValue().getString() ).toLowerCase();
//$NON-NLS-1$
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Errors with DNs containing non-ASCII values on Active Directory
> ---------------------------------------------------------------
>
> Key: DIRSTUDIO-861
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-861
> Project: Directory Studio
> Issue Type: Bug
> Components: studio-ldapbrowser
> Environment: Darwin 11.4.2 Darwin Kernel Version 11.4.2: Thu Aug 23
> 16:25:48 PDT 2012; root:xnu-1699.32.7~1/RELEASE_X86_64 x86_64
> Reporter: Anatolij N.
> Assignee: Pierre-Arnaud Marcelot
> Priority: Major
> Fix For: 2.0.0-M6 (2.0.0.v20130308), 2.0.0
>
>
> Can't get members of OU, errors occur, first occuring error stacktrace:
> {code:title=Error 1|borderStyle=solid}
> Error while reading entry
> - 269
> java.lang.ArrayIndexOutOfBoundsException: 269
> at
> org.apache.directory.shared.util.Strings.toLowerCase(Strings.java:1813)
> at
> org.apache.directory.studio.ldapbrowser.core.utils.Utils.getOidString(Utils.java:132)
> at
> org.apache.directory.studio.ldapbrowser.core.utils.Utils.getOidString(Utils.java:117)
> at
> org.apache.directory.studio.ldapbrowser.core.utils.Utils.getNormalizedOidString(Utils.java:98)
> at
> org.apache.directory.studio.ldapbrowser.core.model.impl.BrowserConnection.getEntryFromCache(BrowserConnection.java:174)
> at
> org.apache.directory.studio.ldapbrowser.core.jobs.SearchRunnable.searchAndUpdateModel(SearchRunnable.java:341)
> at
> org.apache.directory.studio.ldapbrowser.core.jobs.InitializeChildrenRunnable.executeSearch(InitializeChildrenRunnable.java:359)
> at
> org.apache.directory.studio.ldapbrowser.core.jobs.InitializeChildrenRunnable.initializeChildren(InitializeChildrenRunnable.java:210)
> at
> org.apache.directory.studio.ldapbrowser.core.jobs.InitializeChildrenRunnable.run(InitializeChildrenRunnable.java:169)
> at
> org.apache.directory.studio.connection.core.jobs.StudioConnectionJob.run(StudioConnectionJob.java:109)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
> 269
> {code}
> After first error message I get second message:
> {code:title=Error 2|borderStyle=solid}
> Error while reading entry
> java.lang.ArrayIndexOutOfBoundsException
> java.lang.ArrayIndexOutOfBoundsException
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
