Le 12/07/2018 à 10:47, Radovan Semancik a écrit : > On 07/12/2018 01:25 AM, Emmanuel Lécharny wrote: >> It's almost a 10 years old code (OMG, I can't believe I wrote that >> already 9 years ago...), and my guess is that when I added the list of >> throwable, I forgot to remove the other method, which hasn't eveolved >> since then, which explain why the code is so different. >> >> I thi,k we are safe if you simply remove the method you have renamed... > > Done. Gone. :-) > >> >>> 2) Ava. I think Ava is supposed to be a simple object, almost like a >>> DTO. >> Not sure what you mean by DTO in this context... Because it's >> serializable ? > > Ava is supposed to be (almost) simple data class without (much) > dependencies on anything else in the API. At least that's how I > understand it.
DTO carries some semantic that doe snot necessary apples to Ava (ie, a DTO is supposed to be a Java object that contain data that can be sent over the network (Data Transfert Object). In a way, it's correct, as a DN is serialized to be sent to and from a LDAP server. That why I asked. But Pojo/DTO/VO are names used in a J2EE context. I'm not too much in using such acronyms. At least, I never have them in mind when I code... To me, Ava is just a Java class, and it does what it has to be done... Regardless... >> Good job. Have you tried to build the server with those changes ? If >> not, I will do that tomorrow evening. > > No, I haven't tried the server nor studio. I have and I fixed the one ApacheDS compilation error, and the server compile and builds. Committing the change atm. We are good to go for a API release ! -- Emmanuel Lecharny Symas.com directory.apache.org
pEpkey.asc
Description: application/pgp-keys
