bdemers commented on issue #20: IDEA: Replace restfuse with Rest Assured based tests URL: https://github.com/apache/directory-scimple/pull/20#issuecomment-411503570 There are a few points/questions here :) * Hamcrest comes in with JUnit * Starting a server under test (in this case Tomee) should be managed by the test/test infrastructure. (not out of band i.e. Maven pre-integration-test). This allows for tests to run via an IDE as well as via the command line, which makes for a great developer experience. The `scim-example-memory` module is a war, so it _should_ be tested that way (for ITs anyway) * Re: JUnit 5 + Arquillia - ugg... I guess there are other options for Arquillia, using a rule maybe 🤔, or just stay with JUnit 4 until that tooling around 5 matures ? * Change outside of the test might have shown up before I rebased. If you see something specific now let me know. There _should_ only be changes related to the new ITs and running them. * Adding tests to detect breaking changes 100% the goal of this PR ;) I just wanted to get feed back before I added other ITs. I think maybe we should reduce scope of the compliance module: * Rename it ? - I love the generic compliance test use case, but it might be easier to start with something project specific and work out from there? (focusing on this project's needs first), mark the classes as `internal` so we are not bound to keep it backward compatible (allowing us to rev fast on the tests) * Sort out the testing frameworks with something off the shelf, (including something that can launch and run the examples, assuming we will add more examples) * Maybe even launch the example apps from maven in a pre-IT phase (though I loathe suggesting that)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
