I personnaly only use gitbox. I don't really like github, I don't get
all the fuzz around it - call me old school -.
I get it that PRs are a good way to get a peer review before the code is
committed, but with git creating a branch to play with is not so much a
burden, and we do trust each other so that people don't commit wildly,
so peer reviews is not necessarily useful.
Don't get me wrong: I do think that peer review might be a good thing,
but generally speaking, it's two expensive a tool. I'd rather expose my
proposals on the mailing list, asking for approval or objections, before
going on - in, a branch if needed -.
So github is more a tool for non-committers, it's 'easier' for them to
push code/diff rather than using JIRA, but for committer, it has the
biggest inconvenient to create a side channel for communication, when we
all use the dev mailing list.
All of that are just IMHO, of course ;-)
On 20/12/2018 07:25, Stefan Seelmann wrote:
On 12/20/18 12:43 AM, Shawn McKinney wrote:
On Dec 19, 2018, at 4:16 PM, Lothar Haeger <[email protected]>
wrote:
I've already managed to link my shiny brand new Apache ID ("lhaeger") to my
GitHub account, so a first question would be: what - if any - are the pros and
cons of using gitbox vs github?
Good question. I’ll probably use gitbox, just so I can (continue to) use my
apache credentials. Being able to commit via github is something new for us,
and requires the repo to have been moved into gitbox.apache.org, something that
hasn’t happened yet across all project repos.
For Studio, LDAP API, and server which are already on gitbox I normally
use Github. Advantage is that with Github I can use my SSH keys so don't
have to type in my ASF password or mess with credential helper.
On a git push to either github or gitbox the changes are replicated to
the other. However just yesterday when gitbox was down [1] I pushed to
github but it wasn't forwarded to gitbox so I had to push again manually
to gitbox later. For that I always have both remotes configured:
$ git remote -v
apache https://gitbox.apache.org/repos/asf/directory-server.git (fetch)
apache https://gitbox.apache.org/repos/asf/directory-server.git (push)
github [email protected]:apache/directory-server.git (fetch)
github [email protected]:apache/directory-server.git (push)
Biggest advantage of the gitbox/github integration is that we can create
and accept and merge pull requests directly.
Kind Regards,
Stefan
[1] https://status.apache.org/
