Hi all, for some weeks I work on a branch to remove JNDI from Studio.
One part was removal of the JNDI network provider and the provider choice in the connection settings, that was easy. The other part was removal of the JNDI abstraction layer, and direct usage of our LDAP API instead. To illustrate, before the conversion was * With JNDI provider: Studio model <--> JNDI * With LDAP API provider: Studio model <--> JNDI <--> LDAP API Especially in the 2nd case doing 2 conversions was error prone [1][2][3] and complex. Now the conversion is just * Studio model <--> LDAP API Beside the JNDI removal also other changes are included: * Many more tests were added * Certificate validation improvements [4] * Update to LDAP API and server master (required by previous) * Update to commons lang3 and collections 4 (required by previous change) Tests pass with both Java 8 and 11. Given the additional tests I'm quite confident that everything works well. However it's a huge change [5], and the previous workaround switching to JNDI won't exist any more. I'd like to merge it into master, latest when LDAP API and server versions are released. If anyone wants to review [5] or test the branch with real LDAP servers would be much appreciated :) Kind Regards, Stefan [1] https://issues.apache.org/jira/browse/DIRSTUDIO-1160 [2] https://issues.apache.org/jira/browse/DIRSTUDIO-1199 [3] https://issues.apache.org/jira/browse/DIRSTUDIO-1204 [4] https://issues.apache.org/jira/browse/DIRSTUDIO-1205 [5] https://github.com/apache/directory-studio/pull/21
