Anuhan Torgonshar created DIRSERVER-2270:
--------------------------------------------
Summary: Inconsistent log level practices
Key: DIRSERVER-2270
URL: https://issues.apache.org/jira/browse/DIRSERVER-2270
Project: Directory ApacheDS
Issue Type: Improvement
Components: core
Affects Versions: 2.0.0.AM25
Reporter: Anuhan Torgonshar
Hi,
I found there are inconsistent log level practices in the Qpid project, and we
suspect the following practice should be fixed.
The detail code as well as the modification suggestion are shown below.
{code:java}
problematic logging practice:
====================DefaultDirectoryServiceFactory.java==================
file path:
apacheds-parent-2.0.0.AM25\core-annotations\src\main\java\org\apache\directory\server\core\factory\DefaultDirectoryServiceFactory.java
logging statement line: 151
modification suggestion: change log level to ERROR
145 try
146 {
147 FileUtils.deleteDirectory( instanceLayout.getInstanceDirecto ry() );
148 }
149 catch ( IOException e )
150 {
151 LOG.warn( "couldn't delete the instance directory before ini tializing
the DirectoryService", e );
152 }
similar code snippet:
====================IntegrationUtils.java================================
file path:
apacheds-parent-2.0.0.AM25\core-integ\src\main\java\org\apache\directory\server\core\integ\IntegrationUtils.java
logging statement line: 91
85 try
86 {
87 FileUtils.deleteDirectory( wkdir );
88 }
89 catch ( IOException e )
90 {
91 LOG.error( I18n.err( I18n.ERR_115 ), e );
92 }
{code}
We will highly appreciate your feedback!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
