seelmann commented on a change in pull request #15: [DIRAPI-353] automatic
module names are added
URL: https://github.com/apache/directory-ldap-api/pull/15#discussion_r394137006
##########
File path: all/pom.xml
##########
@@ -126,6 +126,13 @@
</artifactSet>
<promoteTransitiveDependencies>true</promoteTransitiveDependencies>
<createSourcesJar>true</createSourcesJar>
+ <transformers>
+ <transformer
implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
+ <manifestEntries>
+
<Automatic-Module-Name>apache.directory.ldap.api.all</Automatic-Module-Name>
Review comment:
@solomax @elecharny should't the name here (and in other poms) start with
`org.` prefix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
