wenxuanguan commented on a change in pull request #45:
URL: https://github.com/apache/directory-kerby/pull/45#discussion_r501635599
##########
File path:
kerby-backend/ldap-backend/src/main/java/org/apache/kerby/kerberos/kdc/identitybackend/LdapIdentityBackend.java
##########
@@ -51,13 +51,18 @@
import java.util.Collections;
import java.util.List;
import java.util.Map;
+import java.util.HashMap;
/**
* An LDAP based backend implementation.
*/
public class LdapIdentityBackend extends AbstractIdentityBackend {
+ private int currentConnectionIndex = 0;
+ private Map<String, LdapConnection> connections = new HashMap<>();
Review comment:
@coheigea Thanks for your review.
The changes in `connections` is in the constructor of LdapIdentityBackend or
`doInitialize`, which should not be called
multi-thread, so I think there is no thread-safety problem, anything I
missed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
