Dieken commented on pull request #45: URL: https://github.com/apache/directory-server/pull/45#issuecomment-752140910
**This PR is just for your reference, it's a rude hack, so I suggest not merging.** It's better the code is separated into a new authentication interceptor, but: (1) There is no gap between `ads-interceptororder` in `config.ldif`, it's better use 10, 20, 30, ... instead of 1, 2, 3, ... for `ads-interceptororder` (2) `service-builder/src/main/java/org/apache/directory/server/config/builder/ServiceBuilder.java` gives `ppolicyContainer` only to the concrete class `AuthenticationInterceptor`, but my new interceptor also need this object, actually my new interceptor depends on some code in `AuthenticationInterceptor`, those common code should be refactored into a new class, and the `ppolicyContainer` should be injected to some AbstractAuthenticationInterceptor, or better use dependency injection to provide it to any interceptor. (3) the `msad.ldif` shouldn't be at `ldif-partition/src/main/resources/`, it's just committed into the source tree for the record, not worth committing to package `api-ldap-schema-data`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
