[ 
https://issues.apache.org/jira/browse/DIRAPI-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325155#comment-17325155
 ] 

Florian Kimmann commented on DIRAPI-369:
----------------------------------------

I think strings should always be escaped instead of getting base64 encoded. 
Otherwise you cannot tell if a value is a plain string or base64 encoded. 

"SVEN" and "w4RyenRl" both are valid base64 values.

 

Is this something that would get merged if I make a pull request to include 
proper xml escaping?

> DSML needsBase64Encoding
> ------------------------
>
>                 Key: DIRAPI-369
>                 URL: https://issues.apache.org/jira/browse/DIRAPI-369
>             Project: Directory Client API
>          Issue Type: Bug
>            Reporter: Florian Kimmann
>            Priority: Major
>
> Why does the method  needsBase64Encoding in the dsml ParserUtils check for 
> LDIF safety?
> DSML doesnt have to be LDIF safe? We get Base64 encoded strings in our 
> application all the time, because of  common german characters like äöüß etc.
> XML can handle those characters. Or am I overlooking something?
>  
> [https://github.com/apache/directory-ldap-api/blob/275b9830b8b974dc19fb3b8d38c68061211fb5f7/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/ParserUtils.java#L167]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to