elecharny commented on pull request #46: URL: https://github.com/apache/directory-server/pull/46#issuecomment-827380031
I think the PR should be merged with trunk. The reason the tests are slow is probably because of an issue in teh way we deal with 'rollbacks' in tests. Let me explain: - when we start a test in a class containing many, we set a mark, and at the end of the test - whether it's a success or a failure - we rollback the modifications that have been applied during the test (we have an interceptor that registers every modification and compute the reverse operation). - for some reason, I suspect that we don't move the mark forward after each test (we should), and the consequence is that we replay *all* the reverse operation for *all* the already run tests. This is cumulative. - I have fixed the issue but have had to rollback it due to some other test failures my push has induced. Note that this is an hypothesis, which I see confirmed on master before my reverted fix. I will try to get master fixed this week. On 27/04/2021 08:29, Colm O hEigeartaigh wrote: > @seelmann <https://github.com/seelmann> Should that commit have gone > straight to master? Not sure why it was merged to this PR? By the way on > master, the "apacheds-core-integ" tests are now running /very/ slowly on > my machine with the latest junit changes. > > — > You are receiving this because your review was requested. > Reply to this email directly, view it on GitHub > <https://github.com/apache/directory-server/pull/46#issuecomment-827348940>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAWJQFOTLVTKLTM66MGHTXDTKZKVJANCNFSM43MFZAFA>. > -- *Emmanuel Lécharny - CTO* 205 Promenade des Anglais – 06200 NICE T. +33 (0)4 89 97 36 50 P. +33 (0)6 08 33 32 61 ***@***.*** https://www.busit.com/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
