Committed and pushed, all issues are resolved, OSGi tests work again.
On 5/13/21 9:20 AM, Emmanuel Lécharny wrote:
> OH, GREAT !
>
> Please commit, I'll check for the missing deps.
>
>
> On 13/05/2021 08:46, Stefan Seelmann wrote:
>> I got them to run, but some fail because of unresolved requirements. Let
>> me know if I should commit it and investigate further:
>>
>> diff --git a/osgi-integ/pom.xml b/osgi-integ/pom.xml
>> index f993450965..527b31c51f 100644
>> --- a/osgi-integ/pom.xml
>> +++ b/osgi-integ/pom.xml
>> @@ -249,8 +249,8 @@
>> </dependency>
>>
>> <dependency>
>> - <groupId>org.junit.jupiter</groupId>
>> - <artifactId>junit-jupiter-engine</artifactId>
>> + <groupId>junit</groupId>
>> + <artifactId>junit</artifactId>
>> <scope>test</scope>
>> </dependency>
>>
>> @@ -312,6 +312,7 @@
>> <configuration>
>> <includeScope>runtime</includeScope>
>>
>> <outputFile>${project.build.directory}/test-classes/deps.txt</outputFile>
>> +
>> <excludeGroupIds>org.junit.jupiter,org.junit.platform,org.apiguardian</excludeGroupIds>
>>
>> </configuration>
>> </execution>
>> </executions>
>> @@ -327,6 +328,13 @@
>>
>> <forkedProcessExitTimeoutInSeconds>1</forkedProcessExitTimeoutInSeconds>
>> <rerunFailingTestsCount>1</rerunFailingTestsCount>
>> </configuration>
>> + <dependencies>
>> + <dependency>
>> + <groupId>org.apache.maven.surefire</groupId>
>> + <artifactId>surefire-junit47</artifactId>
>> + <version>3.0.0-M3</version>
>> + </dependency>
>> + </dependencies>
>> </plugin>
>> <!--This plugin's configuration is used to store Eclipse m2e
>> settings
>> only. It has no influence on the Maven build itself. -->
>>
>>
>>
>> On 5/13/21 8:13 AM, Emmanuel Lécharny wrote:
>>> The weird thing is that there is only one difference between the working
>>> osgi-integ version and the not running one:
>>>
>>> <dependency>
>>> <groupId>org.junit.jupiter</groupId>
>>> <artifactId>junit-jupiter-engine</artifactId>
>>> <scope>test</scope>
>>> </dependency>
>>>
>>> replaced
>>>
>>> <dependency>
>>> <groupId>junit</groupId>
>>> <artifactId>junit</artifactId>
>>> <scope>test</scope>
>>> </dependency>
>>>
>>>
>>> If I roll back this change, I get the same result.
>>>
>>> So it must be something on the parent pom.
>>>
>>> On 13/05/2021 07:45, Emmanuel Lécharny wrote:
>>>> Ok, I know that the OSGi tests were running on commit
>>>> 2ec1117fec41919a68d04ba3a51724562e3b46f8 ("Updating Jetty to
>>>> 9.4.34.v20201102", made by Colm on Nov 6th) and stopped being run with
>>>> commit 04212704be56cdcb750ca571081a5e55fa03bfb8 ("Started the
>>>> migration to Junit 5", made by me on Dec, 23th).
>>>>
>>>>
>>>>
>>>> On 12/05/2021 09:18, Emmanuel Lécharny wrote:
>>>>> Will analyse further tonite.
>>>>>
>>>>> FTR I have added a test class, which get executed, which means the
>>>>> tests are somehow visible. May be an issue with the
>>>>> RunWith(PaxExam.class) ?
>>>>>
>>>>> On 12/05/2021 06:47, Stefan Seelmann wrote:
>>>>>> On 5/11/21 11:45 PM, Emmanuel Lécharny wrote:
>>>>>>> And after going back to the existing project (44) parent, I can't
>>>>>>> have
>>>>>>> the osgi-integ test run at all :
>>>>>>>
>>>>>>> [INFO] --- maven-surefire-plugin:3.0.0-M3:test (default-test) @
>>>>>>> apacheds-osgi-integ ---
>>>>>>> [INFO]
>>>>>>> [INFO] -------------------------------------------------------
>>>>>>> [INFO] T E S T S
>>>>>>> [INFO] -------------------------------------------------------
>>>>>>> [INFO]
>>>>>>> [INFO] Results:
>>>>>>> [INFO]
>>>>>>> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
>>>>>>> [INFO]
>>>>>>> ...
>>>>>>>
>>>>>>>
>>>>>>> This is more than bizarre...
>>>>>>
>>>>>> Same happens currently in master e.g. on Jenkins. I assume we need to
>>>>>> add the junit-vintage dependency.
>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: [email protected]
>>>>>> For additional commands, e-mail: [email protected]
>>>>>>
>>>>>
>>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [email protected]
>> For additional commands, e-mail: [email protected]
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
