bdemers commented on code in PR #213:
URL: https://github.com/apache/directory-scimple/pull/213#discussion_r1084722794
##########
scim-spec/scim-spec-schema/src/main/java/org/apache/directory/scim/spec/filter/InMemoryScimFilterMatcher.java:
##########
@@ -158,8 +159,11 @@ public boolean test(R actual) {
// now walk the attribute path again to get the accessor and value
Schema.Attribute schemaAttribute =
attributeContainer.getAttribute(attributeReference.getAttributeName());
- actual = schemaAttribute.getAccessor().get(actual);
-
+ if (actual instanceof ScimResource) {
+ // actual is the top level scim resource - need to extract the top
attribute.
+ // otherwise we can move on directly to the sub-attribute
+ actual = schemaAttribute.getAccessor().get(actual);
+ }
Review Comment:
@erant10
🤔 This bit has me confused.
Locally, I reverted this back the previous try/catch/todo, and all the tests
pass.
But I haven't been able to figure out what condition causes this error. Any
ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
