erant10 commented on code in PR #251:
URL: https://github.com/apache/directory-scimple/pull/251#discussion_r1098050861
##########
scim-core/src/main/java/org/apache/directory/scim/core/repository/PatchHandlerImpl.java:
##########
@@ -279,11 +300,14 @@ public <T extends ScimResource> void applyMultiValue(T
source, Map<String, Objec
throw new UnsupportedFilterException("Attribute cannot be added,
only comparison expressions are supported when the existing item does not
exist.");
}
AttributeComparisonExpression comparisonExpression =
(AttributeComparisonExpression) valuePathExpression.getAttributeExpression();
+ checkPrimary(subAttributeName, items, value);
- items.add(Map.of(
+ items.add(new HashMap<>(Map.of(
Review Comment:
No I suppose it doesn't. Thing is `Map.of` creates an Immutable map by
default, which later causes trouble when we try to call `put`... I was trying
to solve it when I came across
[this](https://stackoverflow.com/questions/54963337/create-mutable-collections-map-of-and-list-of)....
But I am open to any suggestions of course
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
