Hi Brian, Shawn
On 29/03/2023 14:32, Shawn McKinney wrote:
On Mar 27, 2023, at 2:29 PM, Brian Demers <[email protected]> wrote:
I took a pass at updating the Directory parent pom.
I updated to the latest apache pom and a bunch of other plugin versions:
https://github.com/apache/directory-project/pull/3
Of note, I changed how the compiler plugin gets configured; this removes a
deprecated (no-op) warning from child projects and moves the config to maven
properties which makes them easier to update in child projects (or possibly
profiles)
There is a lot in PR, so if someone feels strongly about it, I can break it up
into smaller sections, maybe something like parent pom version, plugin
versions, and compiler plugin config)
Thanks for doing this Brian, much overdo. I glanced at it and it looks OK.
I'll commit the change.
I created another PR to remove the dead Geronimo tools plugin.
https://github.com/apache/directory-project/pull/4
There may be more opinions over this one? I ran into issues with how it worked
with the example projects that are built in Directory SCIMple, the NOTICE file
was not detected. I ended up hacking around it by disabling some of the checks:
https://github.com/apache/directory-scimple/blob/7e08c6a0b3da4681845f3a565e72eb0d5f620b55/scim-server-examples/scim-server-memory/pom.xml#L62-L68
This plugin is also not marked as threadsafe when trying to perform
parallelized maven builds.
For the most part, the Rat plugin _should_ accomplish similar goals. My
suggestion is to remove this plugin from the Directory parent pom. Any
projects that still require this plugin can add the configuration directly in
its pom.
So here I’m confused. Our projects must pass the rat plugin checks during
release. You’re not recommending we disable those checks. Is it we disable the
Geronimo tools plugin (I have no idea what it does) and use rat to perform its
checks instead? Would want to understand better what’s going on here.
Sorry, don’t have better knowlege. Perhaps Emmanuel or Stefan can chime in.
Definitely want to test out the changes in the other projects to ensure
releases aren’t impacted down the road.
The rat plugin should take care of all the missing N&L files, so the
Geronimo tool should not be necessary. I'll check that on the API,
AapcheDS and Studio.
Thanks !
--
*Emmanuel Lécharny - CTO* 205 Promenade des Anglais – 06200 NICE
T. +33 (0)4 89 97 36 50
P. +33 (0)6 08 33 32 61
[email protected] https://www.busit.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
