OK makes sense, I'll change the default pull request builder to use Java 11.
Colm. On Wed, May 3, 2023 at 3:07 AM Emmanuel Lécharny <elecha...@gmail.com> wrote: > > At the same time, it may be time we swithc to a more recent JDK when it > comes to build the project. > > Building with a Java 8 target makes sense, but requiring to run the > build with Java 8 is a bit too much, IMHO... > > On 03/05/2023 04:01, Emmanuel Lécharny wrote: > > Ah, no; sorry my mistake. > > > > Actually, it works but it requires Java 11 to be used when running Maven. > > > > I'll comment the plugin. > > > > On 02/05/2023 08:30, Colm O hEigeartaigh wrote: > >> Hi Emmanuel, > >> > >> This commit is breaking JDK8 support, was it intentional? > >> > >> Colm. > >> > >> On Mon, May 1, 2023 at 7:17 AM <elecha...@apache.org> wrote: > >>> > >>> This is an automated email from the ASF dual-hosted git repository. > >>> > >>> elecharny pushed a commit to branch master > >>> in repository https://gitbox.apache.org/repos/asf/directory-server.git > >>> > >>> commit f6b42a4458eef9b4f7868a7bfef2b41b679c48a8 > >>> Author: emmanuel lecharny <elecha...@apache.org> > >>> AuthorDate: Mon May 1 08:07:40 2023 +0200 > >>> > >>> Added the Maven spdx plugin > >>> --- > >>> pom.xml | 21 +++++++++++++++++++++ > >>> 1 file changed, 21 insertions(+) > >>> > >>> diff --git a/pom.xml b/pom.xml > >>> index 93f497ac8f..335cedfffd 100644 > >>> --- a/pom.xml > >>> +++ b/pom.xml > >>> @@ -489,6 +489,27 @@ > >>> </pluginManagement> > >>> > >>> <plugins> > >>> + <plugin> > >>> + <groupId>org.spdx</groupId> > >>> + <artifactId>spdx-maven-plugin</artifactId> > >>> + <!-- please check for updates on > >>> https://search.maven.org/search?q=a:spdx-maven-plugin --> > >>> + <version>0.6.5</version> > >>> + <executions> > >>> + <execution> > >>> + <id>build-spdx</id> > >>> + <goals> > >>> + <goal>createSPDX</goal> > >>> + </goals> > >>> + </execution> > >>> + </executions> > >>> + <configuration> > >>> + <excludedFilePatterns> > >>> + <param>*.spdx</param> > >>> + </excludedFilePatterns> > >>> + <!-- See documentation below for additional configuration --> > >>> + </configuration> > >>> + </plugin> > >>> + > >>> <plugin> > >>> <groupId>org.apache.maven.plugins</groupId> > >>> <artifactId>maven-checkstyle-plugin</artifactId> > >>> > > > > -- > *Emmanuel Lécharny - CTO* 205 Promenade des Anglais – 06200 NICE > T. +33 (0)4 89 97 36 50 > P. +33 (0)6 08 33 32 61 > emmanuel.lecha...@busit.com https://www.busit.com/ --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
