bdemers commented on code in PR #492:
URL: https://github.com/apache/directory-scimple/pull/492#discussion_r1454154644
##########
scim-spec/scim-spec-schema/src/test/java/org/apache/directory/scim/spec/schema/SchemaTest.java:
##########
@@ -60,12 +60,12 @@ public void setUp() {
*/
@ParameterizedTest
@ValueSource( strings = {
- "schemas/urn:ietf:params:scim:schemas:core:2.0:User.json",
- "schemas/urn:ietf:params:scim:schemas:core:2.0:Group.json",
- "schemas/urn:ietf:params:scim:schemas:core:2.0:ResourceType.json",
- "schemas/urn:ietf:params:scim:schemas:core:2.0:Schema.json",
-
"schemas/urn:ietf:params:scim:schemas:core:2.0:ServiceProviderConfig.json",
- "schemas/urn:ietf:params:scim:schemas:extension:enterprise:2.0:User.json"
+ "schemas/urn_ietf_params_scim_schemas_core_2.0_User.json",
+ "schemas/urn_ietf_params_scim_schemas_core_2.0_Group.json",
+ "schemas/urn_ietf_params_scim_schemas_core_2.0_ResourceType.json",
+ "schemas/urn_ietf_params_scim_schemas_core_2.0_Schema.json",
+
"schemas/urn_ietf_params_scim_schemas_core_2.0_ServiceProviderConfig.json",
+ "schemas/urn_ietf_params_scim_schemas_extension_enterprise_2.0_User.json"
Review Comment:
Can you remove the prefix?
If the string no longer represents the URN, it could be any string:
```suggestion
"schemas/User.json",
"schemas/Group.json",
"schemas/ResourceType.json",
"schemas/Schema.json",
"schemas/ServiceProviderConfig.json",
"schemas/EnterpriseUser.json"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
