bdemers commented on code in PR #541:
URL: https://github.com/apache/directory-scimple/pull/541#discussion_r1523752504
##########
scim-core/src/main/java/org/apache/directory/scim/core/repository/Repository.java:
##########
@@ -69,14 +70,14 @@ public interface Repository<T extends ScimResource> {
*
*
* @param id the identifier of the ScimResource to update and persist.
- * @param version an optional version (usually used as an ETag) that can be
used to optimize update requests, may be compared against, the current {@code
ScimResource.meta.version}.
+ * @param etags optional ETag(s) in 'If-Match' header. If not null, to avoid
dirty writing, {@code ScimResource.meta.version} must match one of this set
(the set should contain only one element, and it must be not weak)
Review Comment:
Should we throw an exception if the ETag is weak? Or should we let the
implementation decide how to handle it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org
