[
https://issues.apache.org/jira/browse/DIRAPI-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893554#comment-17893554
]
Emmanuel Lécharny commented on DIRAPI-410:
------------------------------------------
Actually, in 1.0.X, the code was:
{code:java}
...
boolean isHR = in.readBoolean();
if ( isHR )
{
value = StringValue.deserialize( attributeType, in );
}
else
{
value = BinaryValue.deserialize( attributeType, in );
}
...
{code}
which explain why we have this flag.
In 2.X the value contains the flag.
> unchecked function result in Ava.java
> -------------------------------------
>
> Key: DIRAPI-410
> URL: https://issues.apache.org/jira/browse/DIRAPI-410
> Project: Directory Client API
> Issue Type: Bug
> Reporter: Alex
> Priority: Major
>
> in.readBoolean() reads the next token from the input stream, analyzes it as a
> boolean value (interpreting either "true" or "1" as true, and "false" or "0"
> as false). However, in this trigger, the value in.readBoolean() is not
> assigned to anything and the resulting value is not used in the code. It is
> necessary to either add processing of the received value if necessary, or
> simply delete this method because it is unnecessary.
> https://github.com/apache/directory-ldap-api/blob/ff9b56ecb984bdbed0f4df25da1485e8a4b4a870/ldap/model/src/main/java/org/apache/directory/api/ldap/model/name/Ava.java#L1275-L1281
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
