bdemers commented on PR #694: URL: https://github.com/apache/directory-scimple/pull/694#issuecomment-2522040635
@jasonfagerberg-toast I added a fix to this PR. It's late, and there are a lot of edge cases in this `PatchHandler`, this is one more. I think you are right, and this is valid patch request, although there are a quark with how the Attribute's are parsed (see comments) I also added a test case for a "REMOVE" of a full Extension. I'm not sure if that one is a valid 🤔 (the containing extension object doesn't have a mutability flag, but it's attributes might, which _could_ make it an illegal operation, I'll have to check with the SCIM working group on that). As is I feel it's better to this code path defined and tested, so it's easier to make changes in the future. Please take a quick pass through the code and let me know if you think something is missing or it's confusing. I'll try to take another look when i'm more awake 😴 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
