bdemers commented on PR #707:
URL: 
https://github.com/apache/directory-scimple/pull/707#issuecomment-2626291008

   @joshuapsteele  getting back to this now, sorry about the delay.
   
   I did some poking around related to your question about the where is the 
escape used now.
   It's not used (well, not directly by SCIMple)
   
   The two points where I see that that would need escaping are:
   
   1. A search with a filter in a URL parameter. e.g. `/Users?filter=userName 
eq \"jcoder\"`
   The URL escaping here is left to the JAX-RS framework used which will decode 
the query parameters
   This scenario is covered in: `UsersIT.invalidUserNameFilter()`
   
   2. A patch request, that uses a filter as the `path` e.g. `"path": 
"members[value eq \"jcoder\"]"
   This scenario is covered in `GroupsIT.updateGroupWithPatch`
   
   The longer answer is that the JSON escaping happens by automatically by the 
parser when serialized.
   
   In the example above if I set `path` to the value of `members[value eq 
"jcoder"]`, any JSON library would output something like:
   
   ```json
   {
   "path": "members[value eq \"jcoder\"]"
   }
   ```
   Where the quotes are automatically escaped.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org

Reply via email to