Anu-rag-verma commented on PR #288: URL: https://github.com/apache/directory-server/pull/288#issuecomment-2918169212
Hi @elecharny, I had raised a PR with an incorrect solution due to a copy-paste oversight. The MSG_04100_BIND_FAIL was meant to serve as an example for info log messages. I assumed it was an issue because the function had the same name and class (I18n) as the one defined in the Apache LDAP API. I mistakenly judged the situation by just looking at the class and function names and raised the PR with similar changes. However, I now realize that this would break the existing codebase, as the functionality is already correctly implemented in the Apache Directory Server. Thanks for your review and time! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
