bdemers commented on PR #877: URL: https://github.com/apache/directory-scimple/pull/877#issuecomment-3201285860
A quick review looks great! I just kicked of the CI builds. This changes mirrors the others APIs that include the attributes. (so it should be merged) Related to this topic and the future direction of these APIs, it's starting to feel like these attributes (and other request related info) should be moved to some sort of "context" object (maybe including pagination, user info, include/exclude attributes, etc). This _might) make the API easier to evolve over time. @CS-Birb, after making this change do you have any thoughts on this? (just thinking out loud here) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
