elecharny commented on code in PR #382:
URL: https://github.com/apache/directory-server/pull/382#discussion_r4372881534
##########
interceptors/event/src/main/java/org/apache/directory/server/core/event/EventInterceptor.java:
##########
@@ -110,8 +109,13 @@ public Thread newThread( Runnable runnable )
}
};
- executor = new ThreadPoolExecutor( 1, 10, 1000, TimeUnit.MILLISECONDS,
new ArrayBlockingQueue<Runnable>( 100 ),
- threadFactory );
+ // The listeners may have to wait for the end of the operation which
notifies them
+ // (persistent search listeners read the modified entry), so the queue
must not be
+ // bounded : a rejected notification would make this operation fail.
+ ThreadPoolExecutor threadPoolExecutor = new ThreadPoolExecutor( 10,
10, 1000, TimeUnit.MILLISECONDS,
+ new LinkedBlockingQueue<Runnable>(), threadFactory );
Review Comment:
Not sure this is a good idea: persistent search can last for days, without
any update operations being done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
