[
https://issues.apache.org/jira/browse/DL-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15721557#comment-15721557
]
Liang Xie commented on DL-84:
-----------------------------
grep -R "new HashedWheelTimer" .|grep -v "test"
./distributedlog-client/src/main/java/com/twitter/distributedlog/client/routing/ConsistentHashRoutingService.java:
this.hashedWheelTimer = new HashedWheelTimer(new ThreadFactoryBuilder()
./distributedlog-client/src/main/java/com/twitter/distributedlog/client/DistributedLogClientImpl.java:
this.dlTimer = new HashedWheelTimer(
./distributedlog-core/src/main/java/com/twitter/distributedlog/BKDistributedLogNamespace.java:
this.requestTimer = new HashedWheelTimer(
./distributedlog-service/src/main/java/com/twitter/distributedlog/service/DistributedLogServiceImpl.java:
this.requestTimer = new HashedWheelTimer(
> Reduce HashedWheelTimer instance number
> ---------------------------------------
>
> Key: DL-84
> URL: https://issues.apache.org/jira/browse/DL-84
> Project: DistributedLog
> Issue Type: Improvement
> Components: distributedlog-client, distributedlog-core,
> distributedlog-service
> Affects Versions: 0.4.0, 0.5.0
> Reporter: Liang Xie
> Assignee: Liang Xie
>
> Reading code and finding that we use HashedWheelTimer in OwnershipCache
> Class, from netty HashedWheelTimer java doc we know:
> {quote}
> Do not create many instances.
> HashedWheelTimer creates a new thread whenever it is instantiated and
> started. Therefore, you should make sure to create only one instance and
> share it across your application
> {quote}
> then i grep the code base and found there're several HashedWheelTimer
> instantces be created seems. i think the current code could be improved (to
> reduce the thread num at least?)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
