Github user sijie commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/54#discussion_r92025594
--- Diff: distributedlog-build-tools/pom.xml ---
@@ -0,0 +1,30 @@
+<?xml version="1.0"?>
--- End diff --
I like the idea to organize the checkstyle files into a separated module so
that we don't need to have configuration on each module.
I think we should do the similar thing for findbugs settings. Can you move
the findbug settings to builds-tool module? (It can be a separate jira and pull
request).
Also it might be clear to move the eclipse format settings and the merge-pr
script to builds-tool module too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
