GitHub user franckcuny opened a pull request:
https://github.com/apache/incubator-distributedlog/pull/55
Hack week cleanup
This is still in progress.
- remove trailing white spaces in a few places
- fix some scripts (not rely on git); style consistency
- validate that the vagrant configuration works
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/franckcuny/incubator-distributedlog
fcuny/hack-week-cleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-distributedlog/pull/55.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #55
----
commit 5800829fc9a0751dcc41195550025f77aba7eb39
Author: Franck Cuny <[email protected]>
Date: 2016-12-12T18:43:19Z
Remove Dockerfile and docker directory.
There's already a docker file at the root of the repository. In
addition, this Dockerfile would not work, since you can't create an
image by copying content from a directory outside, since you get the
following error:
% docker build .
...
Forbidden path outside the build context: .. ()
commit 9bf33fc94b58b09b21a1d318c7001a04397b6225
Author: Franck Cuny <[email protected]>
Date: 2016-12-12T18:45:54Z
Create a valid snapshot.
commit 179eddc269653608750ab9c344205f52d4315553
Author: Franck Cuny <[email protected]>
Date: 2016-12-12T21:55:29Z
Ignore .vagrant directory created by vagrant.
commit a7ac7c051fcae3c86e785298c29c736d575580d4
Author: Franck Cuny <[email protected]>
Date: 2016-12-12T21:56:26Z
Git ignore pid files
commit 480bc348694a19fc0be9e78d1f83a45e08e609e8
Author: Franck Cuny <[email protected]>
Date: 2016-12-12T22:17:18Z
Remove comment from Dockerfile
Remove trailing white spaces too.
commit 21d89f8e93d0110bb92f7adc4f85e7e17a490489
Author: Franck Cuny <[email protected]>
Date: 2016-12-12T22:28:15Z
Do not assume git is available in the shell scripts.
Almost all the shell scripts were using `git` to figure out the root
directory of distributedlog, but we can't assume it is available on the
host. We could also not have a .git directory if the package is shipped
in a tarball or other package format.
Reformat some of the scripts to use consistent indentation level.
commit 27f90f13aed5ce87c171024402d05a7975a8ac26
Author: Franck Cuny <[email protected]>
Date: 2016-12-12T22:30:26Z
Rename bookkeeper hosts from node to bk.
It is more obvious than the generic name.
commit a3fc4ef3c85f053b6433b87b64ce72fc7a295659
Author: Franck Cuny <[email protected]>
Date: 2016-12-12T22:31:11Z
Remove trailing white spaces in the doc
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
