[
https://issues.apache.org/jira/browse/DL-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15753481#comment-15753481
]
ASF GitHub Bot commented on DL-123:
-----------------------------------
GitHub user brennonyork opened a pull request:
https://github.com/apache/incubator-distributedlog/pull/75
DL-123: Every tests should have timeout
* used a simple bash script to find any tests without a timeout
Here is the below bash executed from the root directory. This could be
expanded to take in more than one line above the initial `grep` although, for
more, it only reduces the false positive rate. After this patch there are only
4 false positives (tests where the text immediately above is not `@Test(timeout
= ...)`).
```
grep -r "public void test" -B 1 * | awk '($NR+1) % 3 !=0 {printf $0; printf
" "} NR % 3 == 0 {print " "}' | grep -v "timeout"
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brennonyork/incubator-distributedlog DL-123
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-distributedlog/pull/75.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #75
----
commit ece7cde25fd44e913d0b5b15a807fd1d0f28fd89
Author: Brennon York <[email protected]>
Date: 2016-12-16T05:06:29Z
added timeout of 60000 to all tests
----
> Every tests should have timeout
> -------------------------------
>
> Key: DL-123
> URL: https://issues.apache.org/jira/browse/DL-123
> Project: DistributedLog
> Issue Type: Bug
> Reporter: Gerrit Sundaram
> Assignee: Brennon York
> Labels: help-wanted
>
> Currently not every test has timeout value.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
