[
https://issues.apache.org/jira/browse/DL-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763525#comment-15763525
]
Hudson commented on DL-136:
---------------------------
UNSTABLE: Integrated in Jenkins build distributedlog-nightly-build #162 (See
[https://builds.apache.org/job/distributedlog-nightly-build/162/])
DL-136: Avoid empty catch blocks (sijie: rev
deb8d375543db262ca5e9f5010a54eec6e22581b)
* (edit)
distributedlog-benchmark/src/main/java/com/twitter/distributedlog/benchmark/stream/AsyncReaderBenchmark.java
* (edit)
distributedlog-core/src/main/java/com/twitter/distributedlog/metadata/ZkMetadataResolver.java
* (edit)
distributedlog-benchmark/src/main/java/com/twitter/distributedlog/benchmark/stream/SyncReaderBenchmark.java
* (edit)
distributedlog-benchmark/src/main/java/com/twitter/distributedlog/benchmark/stream/LedgerReadBenchmark.java
> Avoid empty catch blocks
> ------------------------
>
> Key: DL-136
> URL: https://issues.apache.org/jira/browse/DL-136
> Project: DistributedLog
> Issue Type: Task
> Reporter: Sijie Guo
> Assignee: Brennon York
> Labels: help-wanted
>
> Based on the code analysis here :
> https://www.kiuwan.com/blog/analyzing_distributedlog_twitter-2/, there are 22
> Times: Catching exceptions with empty bodies.
> {quote}
> There are exceptions of different types: InterruptedException,
> KeeperException, Exception, etc.. Even though we think that these exceptions
> should never occur, if they are captured it means that they are technically
> possible. In case that they do happen, it will be very difficult to know what
> is happening and to diagnose the problem. It is very recommendable, at least
> to add a log trace, in case these exceptions are triggered.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
