DL-104: BKClientReadTimeout can be equal to getReadLACLongPollTimeout so current config validates
Project: http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/commit/316fd94c Tree: http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/tree/316fd94c Diff: http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/diff/316fd94c Branch: refs/heads/master Commit: 316fd94c87c18c3a4da8777152df60a0148d1d36 Parents: ddbd771 Author: Jordan Bull <jb...@twitter.com> Authored: Tue Aug 9 11:36:53 2016 -0700 Committer: Sijie Guo <sij...@twitter.com> Committed: Tue Dec 27 16:49:27 2016 -0800 ---------------------------------------------------------------------- .../com/twitter/distributedlog/DistributedLogConfiguration.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/blob/316fd94c/distributedlog-core/src/main/java/com/twitter/distributedlog/DistributedLogConfiguration.java ---------------------------------------------------------------------- diff --git a/distributedlog-core/src/main/java/com/twitter/distributedlog/DistributedLogConfiguration.java b/distributedlog-core/src/main/java/com/twitter/distributedlog/DistributedLogConfiguration.java index 1f5427c..ebb7ae2 100644 --- a/distributedlog-core/src/main/java/com/twitter/distributedlog/DistributedLogConfiguration.java +++ b/distributedlog-core/src/main/java/com/twitter/distributedlog/DistributedLogConfiguration.java @@ -3466,7 +3466,7 @@ public class DistributedLogConfiguration extends CompositeConfiguration { * Validate the configuration */ public void validate() { - Preconditions.checkArgument(getBKClientReadTimeout() * 1000 > getReadLACLongPollTimeout(), + Preconditions.checkArgument(getBKClientReadTimeout() * 1000 >= getReadLACLongPollTimeout(), "Invalid timeout configuration : bkcReadTimeoutSeconds ("+getBKClientReadTimeout()+ ") should be longer than readLACLongPollTimeout ("+getReadLACLongPollTimeout()+")"); }
