ofuks commented on a change in pull request #588: [Dlab-1422] The endpoint URL
verification
URL: https://github.com/apache/incubator-dlab/pull/588#discussion_r378996587
##########
File path:
services/self-service/src/main/java/com/epam/dlab/backendapi/domain/EndpointDTO.java
##########
@@ -23,14 +23,27 @@
import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
import com.fasterxml.jackson.annotation.JsonProperty;
import lombok.Data;
+import org.hibernate.validator.constraints.URL;
+import javax.validation.constraints.Pattern;
@Data
@JsonIgnoreProperties(ignoreUnknown = true)
public class EndpointDTO {
-
+ /*
+ the URL_REGEXP_VALIDATION constant is a template for URL pattern,
+ i.e for url verification like "https://localhost:8084/a/$-*^.oLeh;/";
Review comment:
I think we should not give examples of invalid URLs. So that we will rid of
the comment because of the name of the field(**URL_REGEXP_VALIDATION**) give us
information about regexp.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
