Questions
1. For your frontend dist tar, why do you require Nginx in your
`install-dolphinscheduler-ui.sh`? Does the frontend depend on Nginx? If
logically yes, Nginx is your dependency lib, and license should be
included. Look like `BSD-2` from
https://github.com/nginx/nginx/blob/master/docs/text/LICENSE. As you are
Java based project, what do we need this? Spring boot should have already a
good container for webapp. Could someone explain this?
2. Where is the documentation for this release? Does every release have its
own doc? Or the documents are same for every release?

Suggestion
1. As you are using many Apache 2.0 licensed libs, if the license file is
standard Apache 2.0 license, you could add a new catalog like this, and no
LICENSE file required.
========================================================================
Apache 2.0 licenses
========================================================================

The following components are provided under the Apache License. See project
link for details.
The text of each license is the standard Apache 2.0 license.

Sheng Wu 吴晟
Twitter, wusheng1108


李 岗 <[email protected]> 于2019年12月1日周日 上午1:35写道:

> Hello DolphinScheduler Community,
>
> This is a call for vote to release Apache DolphinScheduler (Incubating)
> version 1.2.0
>
> Release notes:
>
> https://github.com/apache/incubator-dolphinscheduler/blob/1.2.0/ReleaseNotes.md
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/incubator/dolphinscheduler/1.2.0/
>
> Maven 2 staging repository:
>
> https://repository.apache.org/content/repositories/orgapachedolphinscheduler-1012/org/apache/dolphinscheduler/
>
> Git tag for the release:
> https://github.com/apache/incubator-dolphinscheduler/tree/1.2.0
>
> Release Commit ID:
>
> https://github.com/apache/incubator-dolphinscheduler/commit/5ae23ccd237163807d078a4bbc8e71f9724f1d32
>
> Keys to verify the Release Candidate:
> https://dist.apache.org/repos/dist/dev/incubator/dolphinscheduler/KEYS
>
> Look at here for how to verify this release candidate:
>
> https://github.com/apache/incubator-dolphinscheduler/blob/1.2.0-release/README.md
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
>
> [ ] +0 no opinion
>
> [ ] -1 disapprove with the reason
>
> Checklist for reference:
>
> [ ] Download links are valid.
>
> [ ] Checksums and PGP signatures are valid.
>
> [ ] DISCLAIMER is included.
>
> [ ] Source code artifacts have correct names matching the current release.
>
> [ ] LICENSE and NOTICE files are correct for each DolphinScheduler repo.
>
> [ ] All files have license headers if necessary.
>
> [ ] No compiled archives bundled in source archive.
>
> ________________________________
> DolphinScheduler(Incubator) PPMC
> Gang Li 李岗
>
> [email protected]<mailto:[email protected]>
>

Reply via email to