Hi,

+1 from me.

I checked:

- Incubating in name
- DISCLAIMER-WIP exists
- LICENSE and NOTICE are fine
- No unexpected binary files
- Checked PGP signatures
- Checked Checksums
- Code compiles

Kind Regards,
Furkan KAMACI

On Mon, Dec 9, 2019 at 3:00 PM Sheng Wu <[email protected]> wrote:

> lidong dai <[email protected]> 于2019年12月9日周一 下午7:55写道:
>
> > +1
> >
> > I checked:
> >
> > - The content of the version matches the content of the tag on Github
> > - deployment document is good to me
> >
>
> As a PPMC and active core contributor, you should check more clearly on the
> release.
> You have a full checklist in your document if you are not following, that
> doc is not meaningful. And new PPMC and committer will feel confused.
> Like I talked with some of PPMC yesterday at your meetup, release check is
> the responsibility of the PPMC member.
>
> Sheng Wu 吴晟
> Twitter, wusheng1108
>
>
>
> >
> >
> >
> > Best Regards
> > ---------------
> > DolphinScheduler(Incubator) PPMC
> > Lidong Dai 代立冬
> > [email protected]
> > ---------------
> >
> >
> > Kevin Ratnasekera <[email protected]> 于2019年12月9日周一 下午5:17写道:
> >
> > > +1 ( binding )
> > >
> > > I checked the following.
> > >
> > > 1. Incubating in name.
> > >
> > > 2. PGP Signature.
> > >
> > > 3. SHA512 Checksum.
> > >
> > > 4. DISCLAIMER-WIP exists.
> > >
> > > 5. LICENSE and NOTICE are fine.
> > >
> > > 6. No unexpected binary files.
> > >
> > > 7. Maven build passes.
> > >
> > > Regards
> > >
> > > Kevin
> > >
> > >
> > > On Mon, Dec 9, 2019 at 1:27 PM William-GuoWei <[email protected]>
> > > wrote:
> > >
> > > > +1
> > > > I checked - The release files in correct location - The release files
> > > have
> > > > the word incubating in their name - Checksums and PGP signatures are
> > > valid.
> > > > - DISCLAIMER-WIP is included. - LICENSE and NOTICE files exist. - No
> > > > compiled archives bundled in source archive.
> > > >
> > > >
> > > > Dolphin Scheduler (Incubator) PPMC Member
> > > > William Guo Wei
> > > >  李 岗 [email protected] 于2019年12月6日周五 下午2:45写道:    +1     I
> > > > checked   - The release files in correct location   - The release
> files
> > > > have the word incubating in their name   - Checksums and PGP
> signatures
> > > are
> > > > valid.   - DISCLAIMER-WIP is included.   - LICENSE and NOTICE files
> > > exist.
> > > >  - No compiled archives bundled in source archive.
> > > >  ________________________________   DolphinScheduler(Incubator) PPMC
> > >  Gang
> > > > Li 李岗     [email protected]mailto:[email protected]
> > > >  发件人: [email protected]mailto:[email protected]
>  发送时间:
> > > > 2019-12-05 14:48   收件人: devmailto:[email protected]
> >  主题:
> > > > [VOTE] Release Apache DolphinScheduler (Incubating) 1.2.0 (round 2)
> > >  Thank
> > > > Justin for suggestion,The font and picture may have incomplete
> > >  licensing
> > > > conditions.So replaced DISCLAIMER with DISCLAIMER-WIP in  binaray
>  and
> > > > source code.     Hello DolphinScheduler Community,     This is a call
> > for
> > > > vote to release Apache DolphinScheduler (Incubating)   version 1.2.0
> > > >  Release notes:
> > > >
> > >
> >
> https://github.com/apache/incubator-dolphinscheduler/blob/1.2.0/ReleaseNotes.md
> > > >    The release candidates:
> > > >
> > https://dist.apache.org/repos/dist/dev/incubator/dolphinscheduler/1.2.0/
> > > >    Maven 2 staging repository:
> > > >
> > >
> >
> https://repository.apache.org/content/repositories/orgapachedolphinscheduler-1014/org/apache/dolphinscheduler/
> > > >    Git tag for the release:
> > > > https://github.com/apache/incubator-dolphinscheduler/tree/1.2.0
> > > >  Release Commit ID:
> > > >
> > >
> >
> https://github.com/apache/incubator-dolphinscheduler/commit/a97230f9051411b551793d5a4386e7630365713f
> > > >    Keys to verify the Release Candidate:
> > > >
> https://dist.apache.org/repos/dist/dev/incubator/dolphinscheduler/KEYS
> > > >  Look at here for how to verify this release candidate:
> > > >
> > >
> >
> https://github.com/apache/incubator-dolphinscheduler/blob/1.2.0-release/README.md
> > > >    The vote will be open for at least 72 hours or until necessary
> > number
> > > > of   votes are reached.     Please vote accordingly:     [ ] +1
> approve
> > > >  [ ] +0 no opinion     [ ] -1 disapprove with the reason
>  Checklist
> > > for
> > > > reference:     [ ] Download links are valid.     [ ] Checksums and
> PGP
> > > > signatures are valid.     [ ] Source code artifacts have correct
> names
> > > > matching the current  release.     [ ] LICENSE and NOTICE files are
> > > correct
> > > > for each DolphinScheduler repo.     [ ] All files have license
> headers
> > if
> > > > necessary.     [ ] No compiled archives bundled in source archive.
> > >  More
> > > > detail checklist please refer:
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> > > >    ________________________________   DolphinScheduler(Incubator)
> PPMC
> > > >  Gang Li 李岗     [email protected]:
> > [email protected]
> > >
> >
>

Reply via email to