Hi, +1 from me.
I checked: - Incubating in name - DISCLAIMER-WIP exists - LICENSE and NOTICE are fine - No unexpected binary files - Checked PGP signatures - Checked Checksums - Code compiles Kind Regards, Furkan KAMACI On Sun, Dec 29, 2019 at 6:37 AM leon bao <[email protected]> wrote: > +1 > > i checked: > 1. digital signature and hashes > 2. DISCLAIMER-WIP exist. > 3.LICENSE and NOTICE file exists > 4. LICENSE and NOTICE text correct > 5. NOTICE year correct. > 6.not any unexpected binary files in the release > 7. compile from source rightly, instruction clearly > > lidong dai <[email protected]> 于2019年12月28日周六 下午7:11写道： > > > +1 > > > > I checked: > > 1、release files in correct location > > 2、have the word incubating in the release file > > 3、WIP-DISCLAIMER file exist and LICENSE and NOTICE text is correct > > 4、not found GPL license and some incompatible 3rd party code license > exists > > 5、can compile from source code, instruction is clear > > > > > > Best Regards > > --------------- > > DolphinScheduler(Incubator) PPMC > > Lidong Dai 代立冬 > > [email protected] > > --------------- > > > > > > 李 岗 <[email protected]> 于2019年12月27日周五 上午10:52写道： > > > > > > > > +1 > > > > > > I checked > > > 1. The release files in correct location > > > 2. The release files have the word incubating in their name > > > 3. Checksums and PGP signatures are valid. > > > 4. DISCLAIMER-WIP is included. > > > 5. LICENSE and NOTICE files exist. > > > 6. NOTICE year is correct. > > > 7. No compiled archives bundled in source archive. > > > ________________________________ > > > DolphinScheduler(Incubator) PPMC > > > Gang Li 李岗 > > > > > > [email protected]<mailto:[email protected]> > > > > > > From: Sheng Wu<mailto:[email protected]> > > > Date: 2019-12-26 10:56 > > > To: 李 岗<mailto:[email protected]> > > > Subject: Re: [VOTE] Release Apache DolphinScheduler (Incubating) 1.2.0 > > > (round 3) > > > +1 > > > > > > 1. ASC checked > > > 2. sha512 exist > > > 3. incubating in name > > > 4. no node_modules in the src > > > 5. Compiling passed > > > 6. LICENSE and NOTICE exist > > > 7. Using DISCLAIMER-WIP > > > > > > Suggestions > > > 1. Found some files without ASF header, such as, > > dolphinscheduler-ui/.env, > > > .editorconfig > > > > > > Sheng Wu 吴晟 > > > Twitter, wusheng1108 > > > > > > > > > 李 岗 <[email protected]<mailto:[email protected]>> > > > 于2019年12月25日周三 下午9:18写道： > > > > > > Thank Justin for suggestion,We fixed the following issues. > > > > > > 1. remove ./dolphinscheduler-ui/node_modules/wordwrap/test/idleness.txt > > > 2. redesigned the IconFont and updated the .js file > > > 3. add ASF headers to some sql files. > > > > > > Hello DolphinScheduler Community, > > > > > > This is a call for vote to release Apache DolphinScheduler (Incubating) > > > version 1.2.0 > > > > > > Release notes: > > > > > > > > > https://github.com/apache/incubator-dolphinscheduler/blob/1.2.0/ReleaseNotes.md > > > > > > The release candidates: > > > > https://dist.apache.org/repos/dist/dev/incubator/dolphinscheduler/1.2.0/ > > > > > > Maven 2 staging repository: > > > > > > > > > https://repository.apache.org/content/repositories/orgapachedolphinscheduler-1016/org/apache/dolphinscheduler/ > > > > > > Git tag for the release: > > > https://github.com/apache/incubator-dolphinscheduler/tree/1.2.0 > > > > > > Release Commit ID: > > > > > > > > > https://github.com/apache/incubator-dolphinscheduler/commit/8dc64f085f06bd3354d844b4d1674b84abba03bb > > > > > > Keys to verify the Release Candidate: > > > https://dist.apache.org/repos/dist/dev/incubator/dolphinscheduler/KEYS > > > > > > Look at here for how to verify this release candidate: > > > > > > > > > https://github.com/apache/incubator-dolphinscheduler/blob/1.2.0-release/README.md > > > > > > The vote will be open for at least 72 hours or until necessary number > of > > > votes are reached. > > > > > > Please vote accordingly: > > > > > > [ ] +1 approve > > > > > > [ ] +0 no opinion > > > > > > [ ] -1 disapprove with the reason > > > > > > Checklist for reference: > > > > > > [ ] Download links are valid. > > > > > > [ ] Checksums and PGP signatures are valid. > > > > > > [ ] Source code artifacts have correct names matching the current > > release. > > > > > > [ ] LICENSE and NOTICE files are correct for each DolphinScheduler > repo. > > > > > > [ ] All files have license headers if necessary. > > > > > > [ ] No compiled archives bundled in source archive. > > > > > > More detail checklist please refer: > > > > > > > > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > > ________________________________ > > > DolphinScheduler(Incubator) PPMC > > > Gang Li 李岗 > > > > > > [email protected]<mailto:[email protected]><mailto: > > > [email protected]<http://outlook.com>> > > > > > > > > -- > DolphinScheduler(Incubator) PPMC > BaoLiang 鲍亮 > [email protected] >
