I noticed sonarcloud didn't get the right UT coverage and create PR #1662 to fix it. https://github.com/apache/incubator-dolphinscheduler/pull/1662
And updated maven command as below mvn clean --batch-mode verify org.sonarsource.scanner.maven:sonar-maven-plugin:3.6.1.1688:sonar -Dsonar.host.url=https://sonarcloud.io -Dsonar.organization=${org} -Dsonar.projectKey=${pKey} -Dsonar.login=${token}-Dmaven.test.skip=true can be appended to skip tests, it will get 0% UT coverage, but will cost less time on local testing . For now, Sonarcloud just analysis Java source file. There are still need some work to get fronted code be analyzed. When the work is done, I will infrom it. ------------------ ???????? ------------------ ??????: "nauu"<[email protected]>; ????????: 2020??1??1??(??????) ????0:04 ??????: "[email protected]"<[email protected]>; ????: Re: [discussion] The SonarCloud check in the CI flow Thanks for your reply, this is normal discussion, no need to apologize. I will try the test way in local environment , if there is any problem, i will continue to follow up in this mail. However, I still feel that the method of local testing is too complicated. Such as UT coverage , checkstyle and spotbugs, If the rules are clear, these checks are easy to do in the IDE. BTW, I said causeing merge to slow do not means we should not use SonarCloud. SonarCloud is very useful. But If the rules are clear, and there is a way for local testing, we can get everything right before pull request, instead of trying. [email protected] zhukai/nauu ygsoft > On Dec 31, 2019, at 11:37 PM, ?????? <[email protected]> wrote: > > Sorry for your confuse > > 1. SonarCloud's test standards > For now , SonarCloud use the default Quality Gate analysis new code. if one of these conditions is true, Quality Gate will failed . > > For SonarCloud's testing standards, You can check here : > https://sonarcloud.io/organizations/apache/quality_gates/show/9 > > More metric definitions: > https://sonarcloud.io/documentation/user-guide/metric-definitions/ > > 2. Test in a local development environment > Use maven command will be a easy way , there 2 steps: > 1) Sign up at https://sonarcloud.io/ <https://sonarcloud.io/> , set up organization, projectKey, and token > 2) Run maven command locally , remember replace the variable as you set up at step 1) > mvn clean --batch-mode verify org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -Dsonar.host.url=https://sonarcloud.io -Dsonar.organization=${org} -Dsonar.projectKey=${pKey} -Dsonar.login=${token} > Then your can browse analysis at SonarCloud. > > 3. Cause merge to slow > Adding SonarCloud check in the CI workflow means developers need spend more time on code implementation stage ,but less on testing and debuging. I think it's worthy . > > > ------------------ Original ------------------ > From: "nauu"<[email protected]>; > Date: Tue, Dec 31, 2019 10:36 PM > To: "[email protected]"<[email protected]>; > Subject: [discussion] The SonarCloud check in the CI flow > > Hi : > > I'd like to discuss the SonarCloud check in the CI flow, It makes me a little confused. > > Before this, we have a very clear goal in our project: > The root issue #1460, It defines the overall goal and break into subtasks. Such as [Add unit test] #1465, It defines which unit tests should we write and what is the coverage ratio. > > But now, SonarCloud suddenly added in without discussion in the community(dev maillist).It is obviously unstable, and causing the progress of the merge to slow. > > I'm not quite sure what is the SonarCloud's testing standards, what is our goals, and how to test in a local development environment. > > > [email protected] > zhukai/nauu ygsoft > > > > >
