The file <https://github.com/zhnlk/ali-checkstyle-xml/blob/master/ali-checkstyle.xml> is created at 2017, are u sure?
------------------ ???????? ------------------ ??????: "lidong dai"<[email protected]>; ????????: 2020??2??8??(??????) ????8:59 ??????: "dev"<[email protected]>; ????: "wangyang.03"<[email protected]>; ????: Re: [CI][Code style] Need help with checking code style check by Ali way hi , I see checkstyle.xml ( https://github.com/zhnlk/ali-checkstyle-xml/blob/master/ali-checkstyle.xml) from http://mail-archives.apache.org/mod_mbox/dolphinscheduler-dev/202001.mbox/%3Ctencent_6DF620A15E4A57C43A349736CBCD15454907%40qq.com%3E, is this checkstyle OK ? <https://github.com/zhnlk/ali-checkstyle-xml/blob/master/ali-checkstyle.xml> Best Regards --------------- DolphinScheduler(Incubator) PPMC Lidong Dai ?????? [email protected] --------------- Jave-Chen <[email protected]> ??2020??2??8?????? ????4:41?????? > Hi, all > As we discussed about checkstyle, we agreed use Ali code style. > < > http://mail-archives.apache.org/mod_mbox/dolphinscheduler-dev/202001.mbox/%3Ctencent_6DF620A15E4A57C43A349736CBCD15454907%40qq.com%3E&gt > ; > > > I did some effects with this, and there are some problems now: > 1. I did't find checkstyle config file for Ali code style, which means we > need to&nbsp; > create these rules by ourselves. > 2. Another possible way is to use PMD, but the PMD implementations has > fewer&nbsp; > rules than IDEA plugin or Eclipse plugin.&nbsp; > For example indent check is not implemented by PMD, which I think > is unacceptable. > You can see The PDM implementations and rules&nbsp; at > <https://github.com/alibaba/p3c/tree/master/p3c-pmd&gt; > > > So, is there anyone can help solve these problems?? > Or we have to reconsider Google code style.
