@GabryWu for users, if you use a wrong suffix file in many tasks, cloning cannot reduce workload, but renaming can.
simon <3656...@qq.com> 于2020年5月9日周六 下午5:17写道： > I suggest allowing to change the resource file suffix，because i think this > operation is infrequent and maybe we can assume by default that it has made > problems in use and developers know the impact of changing the suffix. > > > > > > ------------------ 原始邮件 ------------------ > 发件人: "leon bao"<leon...@apache.org>; > 发送时间: 2020年5月9日(星期六) 下午5:10 > 收件人: "dev"<dev@dolphinscheduler.apache.org>; > 抄送: "lgcareer2019"<lgcareer2...@outlook.com>; > 主题: Re: [DISCUSSION] Is it allowed to change the resource file suffix > when update resource name? > > > > there is a issue about this: > https://github.com/apache/incubator-dolphinscheduler/issues/1397 > > in summary, the issue reporter cannot preview the renamed resource when it > was renamed a wrong suffix. > but i think this is not a bug, because if suffix is wrong, you can > rename > a right one. > > @GabryWu > after writing a long code file, i select a wrong suffix. if cannot rename > the suffix, i have to delete the file and create a new one. It's very > inconvenient. > > > @lgcareer2019 > > We should trust the user, before changing the file suffix, user clearly > know the file suffix is wrong. > At the same time, the resource is used as 'resource id' in task > definition, not 'resource name' , so there is nothing with the task > when > renaming the resource suffix. > > > > > > GabryWu <wu_shao_...@qq.com> 于2020年5月9日周六 下午4:06写道： > > > I think the resource file name (including suffix) can't be changed, > which > > contents can be overwritten.&nbsp;&nbsp; > > Why we should consider two files with different suffix is the same > file ? > > If so ,what's meaning of the file suffix? > > > > > > if user want to delete a resource file, a tips telling that the file > is > > used by some job is better > > > > > > ------------------&nbsp;原始邮件&nbsp;------------------ > > 发件人:&nbsp;"lgcareer2...@outlook.com"<lgcareer2...@outlook.com > &gt;; > > 发送时间:&nbsp;2020年5月9日(星期六) 下午3:54 > > 收件人:&nbsp;"dev"<dev@dolphinscheduler.apache.org&gt;; > > > > 主题:&nbsp;[DISCUSSION] Is it allowed to change the resource file > suffix > > when update resource name? > > > > > > > > Hi Dev Team. > > Here is a short topic[1] to discuss. > > Background > > 1. User has created a resource that which name is example and suffix > is > > txt. > > 2. The above resource has been authorzied to other users and it was > used > > by some process definitons. > > > > To Discuss > > If a user need update the resource name,Is it allowed to change the > > resource file suffix when update resource name? > > > > If it is allowed to change the resource file suffix,May be lead to a > > problem that the tasks those which used this resource maybe executed > > failure. > > If it is not allowed to change the resource file,If created the > resource > > and found the resource suffix is wrong,The user has to delete it and > create > > it again. > > > > Please feel free to discuss. > > > > 1.https://github.com/apache/incubator-dolphinscheduler/issues/2598 > > <https://github.com/apache/incubator-dolphinscheduler/issues/2598>>; > > > > > > DolphinScheduler(Incubator) PPMC > > Gang Li 李岗 > > > > lgcareer2...@outlook.com<mailto:lgcareer2...@outlook.com&gt; > > > > -- > DolphinScheduler(Incubator) PPMC > BaoLiang 鲍亮 > leon...@apache.org -- DolphinScheduler(Incubator) PPMC BaoLiang 鲍亮 leon...@apache.org
