Hi,
Thank you very much for your two suggestions. According to some normative practices of other communities, I have made corresponding replies in the previous mailing list [1]. You can see if it can solve this problem. I replied in the mailing list [1] about the benefits and necessity of one-to-one PR and issue. Now I try to understand what you said about the scenario of one PR to many issues. If my understanding is wrong, please point out: I think that the scenario of one PR to many issues are relatively few, and from the root cause, there are scenarios in which multiple issues need to do the same thing. I think there are two solutions to this scenario: the first is to merge multiple issues with the same function into the same issue, and then close other issues. The second is that multiple issues are basically doing one function, but there are some differences. In this way, the responsibilities of each issue should be clearly divided. The type of each issue supposed to be marked as sub task [2], and then these sub task type issues are associated with one issue. When submitting pr, each PR is only targeted at one Issue of sub task. I mainly refer to the PR specification of Apache Flink community. If you are interested, please refer to the PR [3] of Apache Flink Community. If my understanding is not correct, or if you have different opinions, please put forward your understanding of the scenario that a PR corresponds to multiple issues. If there are no other comments, I will send another email about the specifications between the Committer, the contributor and the issue. --------------------------------- ???????????????????????????????????????????????????????????????????????????? [1] ?????????????????????????????????????????????????????????? ???????????? [1] ???????????? pr ?? issue ?????????????????????????????????????????????? pr ?? issue ???????????????????????????????????? ?????? pr ?? issue ?????????????????????????????????? pr ?? issue ?????????????????????????????????? issue ???????????????????????????????????????????????????????????????????????????????????????????? issue ???????????? issue ???????????????? issue ???????????????????????? issue ???????????????????????????????????????????????????????????????? issue ?????????????????????? issue ?????????????? Sub-Task [2]???????????? Sub-Task ?????? issue ?????????????? issue ?????????? pr ???????? pr ???????????? Sub-Task ?? issue?? ?????????????? Apache Flink Community ?? pr ???????????????????????????????? Apache Flink Community ?? pr [3]?? ?????????????????????????????????????????????????????? pr ???????? issue ???????????????? ?????????????????????????????????????????? committer ?? contributor ?? issue ?????????????????????? [1] https://lists.apache.org/thread.html/rd5cf6f2cb3cd5e20b26a55b2fd64a4944ddca7b30307c64cab020862%40%3Cdev.dolphinscheduler.apache.org%3E [2] https://github.com/apache/incubator-dolphinscheduler-website/pull/147 [3] https://github.com/apache/flink/pulls?q=is%3Apr+is%3Aclosed+is%3Amerged Best, Yichao Yang ------------------ ???????? ------------------ ??????: "Jave-Chen"<[email protected]>; ????????: 2020??7??9??(??????) ????7:29 ??????: "dev"<[email protected]>; ????: RE??[Vote] Pull Request Title Specification On one hand, since everyone is free to create issues,&nbsp;different users may create&nbsp; issues for the same reason. On the other hand,&nbsp;spliting a large PR into&nbsp;multiple small PRs requires developers&nbsp; to read all prs, would it be inappropriate ?? ------------------&nbsp;????????&nbsp;------------------ ??????:&nbsp;"CalvinKirs"<[email protected]&gt;; ????????:&nbsp;2020??7??9??(??????) ????2:02 ??????:&nbsp;"[email protected]"<[email protected]&gt;; ????:&nbsp;Re:[Vote] Pull Request Title Specification Hi, I think this is a question worthy of recognition.&nbsp; I think our big pr should be separated, corresponding to an isuess, if it cannot be split, can it be aggregated into an isuess??how do you think??If I am wrong, please correct me Best regards?? CalvinKirs On 07/8/2020 22:22??Jave-Chen<[email protected]&gt; wrote?? A PR may be associated with multiple issues, so writing Issue No. in PR titile may&amp;nbsp; be miscellaneous. ------------------&amp;nbsp;????????&amp;nbsp;------------------ ??????:&amp;nbsp;"Yichao Yang"<[email protected]&amp;gt;; ????????:&amp;nbsp;2020??7??8??(??????) ????9:29 ??????:&amp;nbsp;"dev"<[email protected]&amp;gt;; ????:&amp;nbsp;[Vote] Pull Request Title Specification Hi all, After referring to the practices of other open source communities on the title of pull request, we propose two pre selection schemes for dolphin scheduler. First?? Specification: [`Open Source Project Name`-`Issue No`][`Module Name`] `Pull Request Description` example?? [DS-3333][server] Fix the xxx exception [DS-3333][server] Implement xxx ... Second?? Specification: [`Pull Request Type`-`Issue No`][`Module Name`] `Pull Request Description` example?? [Fix-3333][server] Fix the xxx exception [Feature-3333][server] Implement xxx ... The Pull Request type is shown in the screenshot in [1]. If you agree with the first one as the title of the pull request, reply 1, and the second one reply 2. If there is no other suggestions after 7 days, we will choose the first one. -------------------------------------------------------- ???????????????????????????? Pull Request ???????????????????? DolphinScheduler ?????????????????????????? ???????? Specification: [`Open Source Project Name`-`Issue No`][`Module Name`] `Pull Request Description` example?? [DS-3333][server] Fix the xxx exception [DS-3333][server] Implement xxx ... ???????? Specification: [`Pull Request Type`-`Issue No`][`Module Name`] `Pull Request Description` example?? [Fix-3333][server] Fix the xxx exception [Feature-3333][server] Implement xxx ... Pull Request Type ?????? [1] ???????????? ??????????????????Pull request ????????????1??????????????2????????????????????????????7?????????????????????? Pull Request ?????? [1] Pull Request Type: https://github.com/apache/incubator-dolphinscheduler-website/pull/147 Best, Yichao Yang
