I suggest, The sql node internally realizes the function of sending mail, instead of calling the mail alert plug-in. Plugin is optional, some users may not need the email alert plugin. E.g we. So, It is recommended to extract util methods( MailUtils ), and, mail config move to worker.properties.
-------------------- DolphinScheduler(Incubator) Commtter Hemin Wen 温合民 [email protected] -------------------- JUN GAO <[email protected]> 于2020年7月20日周一 下午3:53写道： > Hi all . > > In this feature, we will put the function of sending email into the alert > email plugin. But I found that SqlTask directly calls the code for sending > emails. As a result, after the email function was moved to the > dolphinscheduler-alert-email module, SqlTask could no longer call the email > code. > > How should we deal with this situation? > > Should SqlTask send emails directly instead of through alert services? If > SqlTask should send notifications through the alert server, then the alert > server should provide something for SqlTask to call. > > If you think that SqlTask should send notifications through the alert > service, then I have a few ideas. You can discuss which is more > appropriate: > > 1. Alert server provides grpc interface or http interface, SqlTask calls > these interfaces to send notifications. > > 2. SqlTask directly inserts an alert data into the table t_ds_alert, and > then the alert server will automatically send a notification > asynchronously. > > Do you have any suggestions? > > DolphinScheduler(Incubator) PPMC > Jun Gao 高俊 > [email protected] >
