+1
We can remove the `intellij-java-code-style.xml` file, keep only the
`checkstyle.xml` file may easy for us to maintain.

In IDEA, we can use the `checkstyle.xml` to format the code by following
config:

`Editor -> Code Style -> Java -> Schema -> Import Schema -> CheckStyle
Configuration`


Jiajie Zhong <[email protected]> 于2021年9月30日周四 下午8:37写道:

> Hi guys,
>
>     When I create a PR in our repo, I found out CI code style failed even
> though
> I format the code in my IDEA. I know that we have two code style checker
> and
> some rule of them are not compatible when I create an issue[1] in github.
> I think
> it’s better to keep single code style rule, it easy for developer and make
> our code
> style consistency.
>
>     I proposal remove the Intellij IDEA code style, due to our CI code
> style using
> reviewdog  with `checkstyle` output. And I already submit a PR[2] of it.
>
>
> [1]: https://github.com/apache/dolphinscheduler/issues/6428 <
> https://github.com/apache/dolphinscheduler/issues/6428>
> [2]: https://github.com/apache/dolphinscheduler/pull/6432 <
> https://github.com/apache/dolphinscheduler/pull/6432>
>
> Best Wish
> — Jiajie
>
>

Reply via email to