> On Jul 15, 2022, at 21:03, Chufeng Gao <[email protected]> wrote:
> 
> Thanks Wenjun for the comment. I agree that we could fix the code style
> incrementally instead of pushing a super big change and blowing up the CI.
> Since I'm not familiar with DS CI, may I ask how much work we need to do in
> the CI side if we pick up Spotless?

If you want to pick up Spotless, once you finished setting up locally,
it's just modifying a command in CI (change from checkstyle plugin to spotless 
plugin)
and removing the ReviewDog related commands, should be a small change in CI.

My concern is more about whether Spotless can work in/with incremental mode,
in another word, developers can `check` AND `apply` ONLY to those files they 
modified,
otherwise it's hard to work if I just change file A and `apply` command fixes 
all files.

Chufeng, can you investigate whether Spotless can work in/with incremental mode 
and
if so, how to do that.

Thanks.

Reply via email to