Hi Jiajie, Thanks for the reply.
I think `we should first add some typical UTs in our test codes(from your third point) and then add docs to our contributor(your point two)` is a good suggestion. In this way, we could have more contributors easily participate in the early stage of this work and it helps keep things in track. About code quality of the future plugins, I agree with your point. It's always good to insist on a higher standard for the UTs especially after our refactoring. BTW, I suggest making this proposal a new DSIP if the community agree it worth one. *Best Regards,* *Chufeng (Eric) Gao* Jiajie Zhong <[email protected]> 于2022年7月26日周二 11:00写道： > Hi chufeng, > > It is a great proposal and please count with me to do it together. > > I agree that we should add `Spotless` first before we make some > changes to our unit tests. And your subtask also look good to me, but > I think the first point "Refactor UTs in each module." should be our > key result, and we should first add some typical UTs in our test > codes(from your third point) and then add docs to our contributor(your > point two), WDYT > > But I do not agree with your point. > > We expect every method of DS core covered but we may slack a bit for > plugins to trade-off between code quality and contributors' patience, as > many of our contributors are tired of writing UTs. > > I think the better way to do that it is requests contributor have to > add unit test and requests them cover as much as possible when they > contribute to DolphionScheduler, it is our responsibility to make sure > new code is quality, otherwise we will have other proposal to improve > UT code quality after we finish this, if new merged PR do not cover > the new adding code. > > -- > Best Wish > — Jiajie >
