Hi simsicon, You are very welcome to join our WeChat group. You could email your WeChat ID to me in private and I will get you in.
However, this doesn't mean WeChat Group is the only or best place for us to communicate and discuss DS issues / DSIPs. Dev email list and GitHub issues are always the first choices we recommend in order to keep the discussions public and easy to refer to. Thanks : ) *Best Regards,* *Chufeng (Eric) Gao* On Thu, Sep 29, 2022 at 9:32 AM simsicon <[email protected]> wrote: > Good idea. by the way, how can I join the wechat group in order to > communicate with you guys? thanks > > On Mon, Sep 26, 2022 at 9:06 PM yann ann <[email protected]> wrote: > > > Dear All, > > > > As we discussed in the WeChat group, the current UT coverage of DS is not > > high, in order to avoid increasing our historical debt. I suggest if it > is > > possible to establish a policy that future PRs must contain the > > corresponding UT code. Of course, PRs that are not suitable for writing > UTs > > are excluded. > > UT should a threshold condition for new PR. The reviewers need to > determine > > whether the current PR is covered by the test case. If not, the > Contributor > > should add the related UT, unless this PR does not need UT. > > Doing so has the following benefits： > > 1. Reviewers can migrate PRs more quickly, reducing reviewing time. > > 2. Submitted PR can get basic quality assurance。 > > 3. No further reduction in current test coverage > > > > Sure, of course there may be some "negative impressions". There is a > small > > probability that it may reduce someone's enthusiasm for submitting PR. > But > > I think the action is generally beneficial and it should be a consensus. > > > > B. R. > > Yann (GithubID: DarkAssassinator) > > > > > -- > > Thanks&Best Regards > > Zhang Zheng >
