Hi Jiajie, This is a great idea, I'm +1 to it. Labeling PRs help ease the pain and avoid mistakes when making a new release. Currently, we are iterating both 3.0.x and 3.1.x, therefore, we may need to use labels instead of milestones to indicate which releases those PR belong to. BTW, as we discussed yesterday, we could also encourage contributors to cp their PRs to the release branch. And we need some labels to indicate whether the PR has been CPed or not.
Thanks *Best Regards,* *Chufeng (Eric) Gao* On Fri, Sep 30, 2022 at 10:40 AM Jiajie Zhong <[email protected]> wrote: > Hey guys, > > To make our release process easier, I plan to mark milestones and > labels required before the PR merged[1], the reason why we need them > because: > > * Label: We required a label with at least one label of > 'feature|bug|improvement|document|chore', to make our changelog can > automatic generation > * Milestone: For easier to cherry-pick PR, currently some of our > milestones only exist in issue and not exists in related PR, it is > difficult to find that PR because GitHub does not have an existing API > to get them, we can only use timeline API[2] to find and filter them, > but if we required each PR must have a milestone, we can directly find > related version pr by search API[3] > > [1]: https://github.com/apache/dolphinscheduler/pull/12222 > [2]: https://docs.github.com/en/rest/issues/timeline > [3]: > https://docs.github.com/en/rest/search#search-issues-and-pull-requests > > -- > Best Wish > — Jiajie >
