imay commented on a change in pull request #252: Support NULLS LAST and NULLS
FIRST syntax
URL: https://github.com/apache/incubator-doris/pull/252#discussion_r230704587
##########
File path: fe/src/main/cup/sql_parser.cup
##########
@@ -205,9 +205,9 @@ terminal String KW_ADD, KW_ADMIN, KW_AFTER, KW_AGGREGATE,
KW_ALL, KW_ALTER, KW_A
KW_INNER, KW_INSERT, KW_INT, KW_INTERVAL, KW_INTO, KW_IS, KW_ISNULL,
KW_ISOLATION,
KW_JOIN,
KW_KEY, KW_KILL,
- KW_LABEL, KW_LARGEINT, KW_LEFT, KW_LESS, KW_LEVEL, KW_LIKE, KW_LIMIT,
KW_LINK, KW_LOAD, KW_LOCAL, KW_LOCATION,
+ KW_LABEL, KW_LARGEINT, KW_LAST, KW_LEFT, KW_LESS, KW_LEVEL, KW_LIKE,
KW_LIMIT, KW_LINK, KW_LOAD, KW_LOCAL, KW_LOCATION,
KW_MAX, KW_MAX_VALUE, KW_MERGE, KW_MIN, KW_MIGRATE, KW_MIGRATIONS,
KW_MODIFY,
- KW_NAME, KW_NAMES, KW_NEGATIVE, KW_NO, KW_NOT, KW_NULL,
+ KW_NAME, KW_NAMES, KW_NEGATIVE, KW_NO, KW_NOT, KW_NULL, KW_NULLS,
Review comment:
You should add these here.
// Keyword that we allow for identifiers
keyword ::=
KW_AFTER:id
{: RESULT = id; :}
| KW_AGGREGATE:id
{: RESULT = id; :}
| KW_AUTHORS:id
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
