chenhao7253886 commented on a change in pull request #283: Fix truncation error
in CastExpr
URL: https://github.com/apache/incubator-doris/pull/283#discussion_r231052560
##########
File path: fe/src/main/java/org/apache/doris/analysis/CastExpr.java
##########
@@ -219,7 +195,9 @@ private void analyze() throws AnalysisException {
@Override
public void analyzeImpl(Analyzer analyzer) throws AnalysisException {
- type = targetType;
+ Preconditions.checkState(!isImplicit);
+ targetTypeDef.analyze(analyzer);
Review comment:
Implicit CastExpr can't call analyze() outside , so targetTypeDef will not
throw NullPointerException.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
