imay commented on a change in pull request #299: Fix failed cases in regression
test
URL: https://github.com/apache/incubator-doris/pull/299#discussion_r232519382
##########
File path: fe/src/main/java/org/apache/doris/rewrite/FoldConstantsRule.java
##########
@@ -58,14 +64,14 @@
public class FoldConstantsRule implements ExprRewriteRule {
public static ExprRewriteRule INSTANCE = new FoldConstantsRule();
- private Multimap<String, FEFunctionInvoker> functions =
ArrayListMultimap.create();
+ private ImmutableMultimap<String, FEFunctionInvoker> functions;
+ private ImmutableSet<String> nonNullResultWithNullParamFunctions;
Review comment:
Need more comment here. I'm not very clear about this attribute's purpose
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
