morningman commented on a change in pull request #313: scheduler routine load job for stream load URL: https://github.com/apache/incubator-doris/pull/313#discussion_r233738436
########## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoad.java ########## @@ -0,0 +1,200 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.load.routineload; + +import com.google.common.collect.Maps; +import org.apache.doris.catalog.Catalog; +import org.apache.doris.common.LoadException; +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.concurrent.locks.ReentrantReadWriteLock; +import java.util.stream.Collectors; + +public class RoutineLoad { + private static final Logger LOG = LogManager.getLogger(RoutineLoad.class); + private static final int DEFAULT_BE_CONCURRENT_TASK_NUM = 100; + + // TODO(ml): real-time calculate by be + private Map<Long, Integer> beIdTomaxConcurrentTasks; + + // stream load job meta + private Map<Long, RoutineLoadJob> idToRoutineLoadJob; + private Map<Long, RoutineLoadJob> idToNeedSchedulerRoutineLoadJob; + private Map<Long, RoutineLoadJob> idToRunningRoutineLoadJob; + private Map<Long, RoutineLoadJob> idToCancelledRoutineLoadJob; + + // stream load tasks meta (not persistent) + private Map<Long, RoutineLoadTask> idToRoutineLoadTask; + private Map<Long, RoutineLoadTask> idToNeedSchedulerRoutineLoadTask; + + private ReentrantReadWriteLock lock; + + private void readLock() { + lock.readLock().lock(); + } + + private void readUnlock() { + lock.readLock().unlock(); + } + + private void writeLock() { + lock.writeLock().lock(); + } + + private void writeUnlock() { + lock.writeLock().unlock(); + } + + public RoutineLoad() { + idToRoutineLoadJob = Maps.newHashMap(); + idToNeedSchedulerRoutineLoadJob = Maps.newHashMap(); + idToRunningRoutineLoadJob = Maps.newHashMap(); + idToCancelledRoutineLoadJob = Maps.newHashMap(); + idToRoutineLoadTask = Maps.newHashMap(); + idToNeedSchedulerRoutineLoadTask = Maps.newHashMap(); + beIdTomaxConcurrentTasks = Catalog.getCurrentSystemInfo().getBackendIds(true) + .parallelStream().collect(Collectors.toMap(beId -> beId, beId -> DEFAULT_BE_CONCURRENT_TASK_NUM)); + lock = new ReentrantReadWriteLock(true); + } + + public int getTotalMaxConcurrentTaskNum() { + readLock(); + try { + return beIdTomaxConcurrentTasks.values().stream().mapToInt(i -> i).sum(); + } finally { + readUnlock(); + } + } + + public void addRoutineLoadJob(RoutineLoadJob routineLoadJob) { + writeLock(); + try { + idToRoutineLoadJob.put(routineLoadJob.getId(), routineLoadJob); + } finally { + writeUnlock(); + } + } + + public void addRoutineLoadTasks(List<RoutineLoadTask> routineLoadTaskList) { + writeLock(); + try { + idToRoutineLoadTask.putAll(routineLoadTaskList.parallelStream().collect( + Collectors.toMap(task -> task.getSignature(), task -> task))); + } finally { + writeUnlock(); + } + } + + public Map<Long, RoutineLoadTask> getIdToRoutineLoadTask() { + return idToRoutineLoadTask; + } + + public void addNeedSchedulerRoutineLoadTasks(List<RoutineLoadTask> routineLoadTaskList) { + writeLock(); + try { + idToNeedSchedulerRoutineLoadTask.putAll(routineLoadTaskList.parallelStream().collect( + Collectors.toMap(task -> task.getSignature(), task -> task))); + } finally { + writeUnlock(); + } + } + + public Map<Long, RoutineLoadTask> getIdToNeedSchedulerRoutineLoadTasks() { + readLock(); + try { + return idToNeedSchedulerRoutineLoadTask; + } finally { + readUnlock(); + } + } + + public List<RoutineLoadJob> getRoutineLoadJobByState(RoutineLoadJob.JobState jobState) throws LoadException { + List<RoutineLoadJob> jobs = new ArrayList<>(); + Collection<RoutineLoadJob> stateJobs = null; + readLock(); + LOG.debug("begin to get routine load job by state {}", jobState.name()); + try { + switch (jobState) { + case NEED_SCHEDULER: + stateJobs = idToNeedSchedulerRoutineLoadJob.values(); + break; + case PAUSED: + throw new LoadException("not support getting paused routine load jobs"); + case RUNNING: + stateJobs = idToRunningRoutineLoadJob.values(); + break; + case STOPPED: + throw new LoadException("not support getting stopped routine load jobs"); + default: + break; + } + if (stateJobs != null) { + jobs.addAll(stateJobs); + LOG.info("got {} routine load jobs by state {}", jobs.size(), jobState.name()); + } + } finally { + readUnlock(); + } + return jobs; + } + + public void updateRoutineLoadJobState(RoutineLoadJob routineLoadJob, RoutineLoadJob.JobState jobState) { + writeLock(); + try { + RoutineLoadJob.JobState srcJobState = routineLoadJob.getState(); Review comment: I think the best place to check this is here. Because you check it somewhere else, e.g., analyze phase, you can not make it an atomic operation. The check and transfer of state should be in one locking block. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
