imay commented on a change in pull request #327: Add path info of replica in 
catalog
URL: https://github.com/apache/incubator-doris/pull/327#discussion_r234507949
 
 

 ##########
 File path: be/src/util/string_util.h
 ##########
 @@ -57,6 +60,23 @@ struct StringCaseLess {
     }
 };
 
+struct PathHash {
 
 Review comment:
   em...
   Other struct can be used for `std::map` or `std::unordered_map`. However 
your `struct` can't be used as a comparator or a hasher for these container. 
   
   So, you'd better to define a function here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to